Pokemon Emerald: Exclude sacred ash post champion #4207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
Zunawe
added
the
is: bug/fix
Exempt-Medic
approved these changes
Nov 18, 2024
nicholassaylor
approved these changes
Nov 27, 2024
Exempt-Medic
added
waiting-on: author
Exempt-Medic
added
waiting-on: core-review
NewSoupVi
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Excludes the hidden item in Navel Rock if event tickets are not randomized and goal is champion, since the event ticket that allows you to reach Navel Rock is locked behind champion.
How was this tested?
Checked the location progress type of the location after
create_regionsto make sure it was excluded. Also ran the code when hidden items were turned off to make sure it didn't crash from the location not existing.